Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: also collect after_dependencies #91234

Merged
merged 1 commit into from Jun 21, 2020
Merged

home-assistant: also collect after_dependencies #91234

merged 1 commit into from Jun 21, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 21, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jun 21, 2020

cc @mweinelt

@Mic92
Copy link
Member Author

Mic92 commented Jun 21, 2020

I think we should backport this one in the sense of also applying the script on home-assistant in stable.

mweinelt
mweinelt approved these changes Jun 21, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM. Thanks!

@Mic92 Mic92 merged commit 681b403 into NixOS:master Jun 21, 2020
@Mic92 Mic92 deleted the hass branch June 21, 2020 18:04
@Mic92
Copy link
Member Author

Mic92 commented Jun 21, 2020

If someone else wants to backport this, I am going to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @mweinelt