Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing vim plugins #91235

Merged
merged 8 commits into from Jun 21, 2020
Merged

Missing vim plugins #91235

merged 8 commits into from Jun 21, 2020

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Jun 21, 2020 •
edited

Motivation for this change

I've added some missing vim plugins using update.py:

rhysd/git-messenger.vim
peitalin/vim-jsx-typescript
mhinz/vim-crates
jaxbot/semantic-highlight.vim
mhartington/oceanic-next
joshdick/onedark.vim
voldikss/vim-floaterm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@onsails onsails requested a review from jonringer as a code owner June 21, 2020 15:13
@ofborg ofborg bot added the 6.topic: vim label Jun 21, 2020
@jonringer
Copy link
Contributor

should be one update commit, then one commit per package addition.

you can use git rebase -i if you just need to drop some of the commits

@onsails
Copy link
Contributor Author

onsails commented Jun 21, 2020

Thanks, fixed

@ofborg ofborg bot requested a review from jorsn June 21, 2020 17:37
@teto teto merged commit b5dc9f6 into NixOS:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onsails @jonringer @teto @Janik-Haag