Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates] haskellPackages.reflex-dom and deps: Fix patch urls #91233

Merged
merged 1 commit into from Jun 22, 2020
Merged

[haskell-updates] haskellPackages.reflex-dom and deps: Fix patch urls #91233

merged 1 commit into from Jun 22, 2020

Conversation

maralorn
Copy link
Member

The previously used PR specific urls do cease to exist after a force
push to the PR branch.

Also manually enable hydra builds for reflex-dom-core until upstream
provides a better fix.

Motivation for this change

I made a mistake in my last PR. Didn‘t know that github behaves this way.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
haskellPackages.reflex-dom and deps: Fix patch urls
357655a 
The previously used PR specific urls do cease to exist after a force
push to the PR branch.

Also manually enable hydra builds for reflex-dom-core until upstream
provides a better fix.
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.monoidal-containers
@GrahamcOfBorg build haskellPackages.patch
@GrahamcOfBorg build haskellPackages.reflex
@GrahamcOfBorg build haskellPackages.reflex-dom-core

@cdepillabout
Copy link
Member

Looks like everything builds on Linux, so I'm merging in!

Thanks for following up here.

@cdepillabout cdepillabout merged commit 286f0c0 into NixOS:haskell-updates Jun 22, 2020
@maralorn maralorn deleted the fix-reflex-patches branch June 22, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout