Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpsoffice: add myself as a maintainer #91257

Merged
merged 1 commit into from Jun 22, 2020
Merged

wpsoffice: add myself as a maintainer #91257

merged 1 commit into from Jun 22, 2020

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented Jun 21, 2020

Motivation for this change

I am using wpsoffice everyday and I've seen on the readme that adding myself as a maintainer would allow me to be notified of every notifications about wpsoffice. I hope I could help you if it is needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x ] Ensured that relevant documentation is up to date
  • [ x ] Fits CONTRIBUTING.md.

@Ma27 Ma27 merged commit ab38702 into NixOS:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants