Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-generate-config: refer to nixos-hardware #91216

Merged
merged 1 commit into from Jun 22, 2020
Merged

nixos-generate-config: refer to nixos-hardware #91216

merged 1 commit into from Jun 22, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 21, 2020 •
edited

Motivation for this change

NixOS/rfcs#70

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Jun 21, 2020
Closed
@Mic92 Mic92 merged commit 7aaffa7 into NixOS:master Jun 22, 2020
@Mic92 Mic92 deleted the nixos-config-generate branch June 22, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra edolstra left review comments

@asymmetric asymmetric asymmetric requested changes

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @prusnak @asymmetric @edolstra