Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/doc: add section on Intel DDX drivers #91261

Merged
merged 1 commit into from Jun 23, 2020
Merged

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 21, 2020

Motivation for this change

Document findings from #19231

Things done
  • Tested using sandboxing (nix.useSandbox
  • Built manual
  • Check informations are correct
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 21, 2020

Rendered:
image

Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went for another round, found some more typos.

I also think it makes sense to reorder the paragraphs, to make it more clear what's the recommended approach and what the workaround for older hardware.

nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/x-windows.xml Outdated Show resolved Hide resolved
@flokli
Copy link
Contributor

flokli commented Jun 22, 2020

LGTM!

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 23, 2020

Thank you for reviewing!

@rnhmjoj rnhmjoj merged commit 1b5e0d4 into NixOS:master Jun 23, 2020
@rnhmjoj rnhmjoj deleted the intel branch July 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants