Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flight plan rebasing #2609

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Flight plan rebasing #2609

merged 4 commits into from
Jun 26, 2020

Conversation

eggrobin
Copy link
Member

The Rebase button discards past (and ongoing) manœuvres, and sets the flight plan initial state to the current state (in terms of mass as well as position and velocity).


Drive-by change: drop the guidance node for one frame when it switches manœuvres; this fixes MuMech/MechJeb2#1276 (though @lamont-granquist wants to leave that one open until the UX is cleaned up a little) and the stock equivalent, whereby guiding to the manœuvre through scheduled burnout would lead to a reorientation to the next manœuvre with the engines still firing.

After this change, at the scheduled end of the burn, MechJeb ceases burn execution (shutting down the engines), and the stock SAS switches to holding attitude.

@pleroy pleroy added the LGTM label Jun 23, 2020
@eggrobin eggrobin merged commit aef945b into mockingbirdnest:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Principia node execution is erroneous with a multi-manœuvre flight plan
2 participants