Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.gi-gtk-declarative: fix build by disabling tests #91237

Merged
merged 1 commit into from Jun 22, 2020

Conversation

balsoft
Copy link
Member

@balsoft balsoft commented Jun 21, 2020

Motivation for this change

gi-gtk-declarative requires an X11 display in its test suite.
X11 display is not available inside nix build sandbox, which makes tests fail.

Solution: disable tests for gi-gtk-declarative.

I'm not sure if manually changing hackage-packages.nix is acceptable in this case. If it isn't, I can regenerate it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@balsoft Can you rebase this on haskell-updates, and remove the relevant packages from the broken list in configuration-hackage2nix.yaml?

gi-gtk-declarative requires an X11 display in its test suite.
X11 display is not available inside nix build sandbox, which makes tests fail.

Solution: disable tests for gi-gtk-declarative.
@balsoft
Copy link
Member Author

balsoft commented Jun 22, 2020

@cdepillabout Done.

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.gi-gtk-declarative
@GrahamcOfBorg build haskellPackages.gi-gtk-declarative-app-simple

@cdepillabout
Copy link
Member

Building on linux, LGTM!

Thanks for sending this!

@balsoft
Copy link
Member Author

balsoft commented Jun 22, 2020

@cdepillabout do you mind if in the future I merge such simple changes to haskell-updates myself?

@cdepillabout
Copy link
Member

@balsoft Yeah, I think I saw that you have the commit bit now, so you should be able to merge in stuff yourself now.

Although, I would prefer that you wait for a review from someone else before merging the next three or four PRs, just to make sure that everything is okay.

After you feel comfortable that no one will need to ask for changes on your PRs, then definitely feel free just merging stuff in.

@balsoft
Copy link
Member Author

balsoft commented Jun 22, 2020

Sure! Will do.

@balsoft balsoft deleted the fix-gi-gtk-declarative branch June 22, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants