Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminus-font: make build reproducible by using gzip -n #91224

Merged
merged 1 commit into from Jun 23, 2020
Merged

terminus-font: make build reproducible by using gzip -n #91224

merged 1 commit into from Jun 23, 2020

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Jun 21, 2020

Motivation for this change

In current master, the terminus font is not reproducible. This is because the Makefile invokes gzip without -n, hence including timestamps.

This pull request adds the missing -n by patching the Makefile.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iblech
Copy link
Contributor Author

iblech commented Jun 21, 2020

(I believe that the tests only failed because of a lack of disk space on the host.)

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 23, 2020

@GrahamcOfBorg build terminus_font

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 23, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from astsmtl June 23, 2020 09:43
rnhmjoj
rnhmjoj approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for spotting this!

@rnhmjoj rnhmjoj merged commit 4b8e31f into NixOS:master Jun 23, 2020
@iblech
Copy link
Contributor Author

iblech commented Jun 24, 2020

Awesome, thank you for the quick review and merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@astsmtl astsmtl Awaiting requested review from astsmtl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iblech @rnhmjoj