Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracy: add capture and update binaries #91229

Merged
merged 2 commits into from Jun 21, 2020
Merged

Conversation

nagisa
Copy link
Contributor

@nagisa nagisa commented Jun 21, 2020

Motivation for this change

These are used to capture the trace without using the GUI tool and
update the saved trace files from older to newer versions. update also
allows to re-compress the trace files for whatever reason one might want
to do it.

Based on top of #91228

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @mpickering @cpcloud

Copy link
Contributor

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These are used to capture the trace without using the GUI tool and
update the saved trace files from older to newer versions. `update` also
allows to re-compress the trace files for whatever reason one might want
to do it.
@danieldk
Copy link
Contributor

Maintainer ping: @mpickering

@Mic92 Mic92 merged commit 5d9cb9a into NixOS:master Jun 21, 2020
@mpickering
Copy link
Contributor

Looks fine to me. I didn't add them originally as I don't use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants