confluent-platform: update 5.3.0 -> 5.5.0 #91231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
| cp -R bin etc share src $out | ||
| rm -rf $out/bin/windows | ||
|
|
||
| cp -R $confluentCli confluent-cli |
There was a problem hiding this comment.
This would be a great usecase for install to also make sure the permissions are correct.
|
Result of 1 package built:
|
|
Result of 1 package built:
|
SuperSandro2000
requested changes
Jan 18, 2021
| @@ -47,15 +47,16 @@ stdenv.mkDerivation rec { | |||
| wrapProgram $p \ | |||
| --set JAVA_HOME "${jre}" \ | |||
| --set KAFKA_LOG_DIR "/tmp/apache-kafka-logs" \ | |||
| --set CONFLUENT_HOME "$out" \ | |||
| --prefix PATH : "${jre}/bin:${bash}/bin:${gnused}/bin" | |||
| done | |||
| ''; | |||
|
|
|||
| meta = with stdenv.lib; { | |||
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing this as the whole thing moved, i will reopen with a more recent version Soon TM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The conluent cli is not open source anymore and now distributed as a binary.
Updated versions and build so that it build again.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)