i3ipc-autotiling: init at d521cd6 #91244
Conversation
Useful autotiling script for i3 & sway.
| python3Packages.buildPythonApplication rec { | ||
| pname = "i3ipc-autotiling"; | ||
| version = "d521cd6d26d0b3aadbd283fe4165235b5df386f2"; | ||
| src = fetchTarball { |
There was a problem hiding this comment.
please use fetchFromGitHub instead.
Co-authored-by: symphorien <symphorien@users.noreply.github.com>
|
|
||
| python3Packages.buildPythonApplication rec { | ||
| pname = "i3ipc-autotiling"; | ||
| version = "d521cd6d26d0b3aadbd283fe4165235b5df386f2"; |
There was a problem hiding this comment.
the nixpkgs manual says you should use the date as version if upstream does not tag versions.
See https://nixos.org/nixpkgs/manual/#sec-package-naming
| mkdir -p "$out/bin" | ||
| cp autotiling.py "$out/bin/autotiling"''; | ||
| postInstall = '' | ||
| makeWrapper ${python3Packages.python.interpreter} $out/bin/${pname}-python-interpreter |
There was a problem hiding this comment.
i3ipc-autotiling-python-interpreter is a strange naming for the executable. Also are you sure the wrapping does not happen automatically by the magic of buildPythonPackage ?
There was a problem hiding this comment.
should i fix it with commits here or should i pull it again?
There was a problem hiding this comment.
You can do the modifications locally wit git commit --amend or git rebase -i and then git push --force-with-lease. This will update the content of the pull request.
Useful autotiling script for i3 & sway.
Motivation for this change
Used it on my other machine, a simple script for automatic switch the tile mode from vertical to horizontal when the window is higher than bigger..
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)