Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls: set RUST_SRC_PATH #89742

Merged
merged 1 commit into from Jun 7, 2020
Merged

rls: set RUST_SRC_PATH #89742

merged 1 commit into from Jun 7, 2020

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Jun 7, 2020

Motivation for this change

rls has racer baked in which needs to know where the rust source
is to be able to do completion for std libs. By default rls will use:
$(rustc --print sysroot)/lib/rustlib/src/rust/src
which is nonexistent, this change sets the correct source path
in a same way like it's done in racer expression.

Tested using rls-vscode, finally completion for std libs works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lblasc
rls: set RUST_SRC_PATH
f7bc0a3 
rls has racer baked in which needs to know where the rust source
is to be able to do completion for std libs. By default rls will use:
$(rustc --print sysroot)/lib/rustlib/src/rust/src
which is nonexistent, this commit sets the correct source path
in a same way like it's done in racer expression.
@lblasc lblasc requested review from LnL7 and Mic92 as code owners June 7, 2020 14:22
@ofborg ofborg bot added the 6.topic: rust label Jun 7, 2020
@ofborg ofborg bot requested a review from symphorien June 7, 2020 14:30
@Mic92 Mic92 merged commit eadcec4 into NixOS:master Jun 7, 2020
@lblasc lblasc deleted the rls-std-completion-fix branch June 8, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@symphorien symphorien Awaiting requested review from symphorien

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lblasc @Mic92