Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulumi: 2.1.0 -> 2.2.1, add kubernetes and postgresql providers #89721

Merged
merged 2 commits into from Jul 3, 2020
Merged

pulumi: 2.1.0 -> 2.2.1, add kubernetes and postgresql providers #89721

merged 2 commits into from Jul 3, 2020

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Update pulumi, add kubernetes and postgresql providers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker offlinehacker self-assigned this Jun 7, 2020
@offlinehacker
Copy link
Contributor Author

CC @peterromfeldhk @MarcoPolo

@ludovicc
Copy link

ludovicc commented Jul 2, 2020

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on macOS catalina
  • executables tested on macOS catalina
  • all depending packages build
Possible improvements
Comments

@offlinehacker offlinehacker merged commit 8346d9f into NixOS:master Jul 3, 2020
@offlinehacker offlinehacker deleted the pkgs/pulumi/2.2.1 branch July 3, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovicc ludovicc ludovicc approved these changes

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

Assignees

@offlinehacker offlinehacker

Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@offlinehacker @ludovicc