Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python package set major updates #89723

Merged
merged 539 commits into from
Jun 13, 2020
Merged

Python package set major updates #89723

merged 539 commits into from
Jun 13, 2020
+2,043 −1,243

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jun 7, 2020 •
edited
Loading

Motivation for this change

The package set has not been updated in a while, and now contains significantly outdated packages.

https://hydra.nixos.org/jobset/nixpkgs/python-unstable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@FRidh FRidh requested a review from jonringer as a code owner June 7, 2020 07:38
@FRidh FRidh changed the title Python unstable Python package set major updates Jun 7, 2020
@FRidh FRidh force-pushed the python-unstable branch 3 times, most recently from 6600a86 to 5841ba9 Compare June 7, 2020 08:30
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jun 7, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/upcoming-python-breakage/7554/1

@FRidh FRidh mentioned this pull request Jun 7, 2020
Closed
10 tasks
@bhipple
Copy link
Contributor

bhipple commented Jun 7, 2020 •
edited
Loading

Looks like a keyring might need some tender loving care:

builder for '/nix/store/0zp5q9zqra8lngiapk1a1abrfi97g991-python3.7-keyring-21.2.1.drv' failed with exit code 1
cannot build derivation '/nix/store/l3rmr6dz94ijvm9iycd4iqhaparywdk5-python3.7-twine-3.1.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/r3bim58y80gq4r9gl1y05m68yd0my6ip-python3.7-python-daemon-2.2.4.drv': 1 dependencies couldn't be built

I have some work attempting to nurse apache-airflow and python-daemon back to health here:
#89746

@FRidh
Copy link
Member Author

FRidh commented Jun 7, 2020

biggest failure right now is probably pylint

@jonringer
Copy link
Contributor

I'll spend some time stabilizing this

@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jun 8, 2020
@jonringer
Copy link
Contributor

jonringer commented Jun 8, 2020 •
edited
Loading

got azure-cli, nixops, pypi2nix, and a few others building again

@FRidh FRidh mentioned this pull request Jun 9, 2020
Closed
10 tasks
@FRidh FRidh force-pushed the python-unstable branch from fc034f0 to e468fb5 Compare June 10, 2020 15:30
@das-g
Copy link
Member

das-g commented Jun 10, 2020

Will the maintainers of the affected packages be notified in any way?

@jonringer
Copy link
Contributor

Will the maintainers of the affected packages be notified in any way?

Most likely not, hydra used to have an email feature, but I believe that has been turned off.

@das-g das-g mentioned this pull request Jun 11, 2020
Closed
FRidh added 5 commits June 11, 2020 10:00
@FRidh
python: pylast: 3.1.0 -> 3.2.1

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
58643bd
@FRidh
python: pylint: 2.4.4 -> 2.5.2
d8db80c
@FRidh
python: pymatgen: 2019.12.22 -> 2020.4.29
516a2f4
@FRidh
python: pymbolic: 2019.2 -> 2020.1
09718f4
@FRidh
python: pynamodb: 4.2.0 -> 4.3.2
c80c660
@FRidh
Copy link
Member Author

FRidh commented Jun 12, 2020

~ 500 more failures and 60 removed packages. I think a third to a half is now a direct failure, so that means its only leaf packages that are left.

Jonathan Ringer and others added 17 commits June 12, 2020 10:33
python3Packages.jaraco_functools: fix build
89307ea
python3Packages.pytest-doctestplus: fix tests
ab1be09
python3Packages.kombu: fix tests
14eb90d
python3Packages.scikitimage: add missing tifffile dep
8a67181
python3Packages.caldav: use github, fix build
db59d20
python3Packages.uvicorn: 0.11.2 -> 0.11.5
b9ace1f
Revert "python3Packages.PySDL2: 0.9.6 -> 0.9.7"
6198425 
This reverts commit 738424b.

patches need to be updated to support new version
python3Packages.libagent: use github for tests
82036a6
@das-g
python3Packages.pytest-rerunfailures: 8.0 -> 9.0
35a6dc6 
fixes #89508

(cherry picked from commit 53481e4)
@das-g
pytest-rerunfailures: add das-g as maintainer
f0cf892 
(cherry picked from commit 46821ed)
python3Packages.pyx: fix src pname
503f9f7
gns3-server: fix build
8c3e931
python3Packages.pylint-plugin-utils: fix build
38397dc
python2Packages.validators: disable url tests
be5804a
python3Packages.sseclient: fix tests
529c2f1
python3Packages.vmprof: fix build, mark not broken
dd35d3b
python3Packages.seekpath: fix build, use github for tests
3ba9e64
@FRidh FRidh mentioned this pull request Jun 13, 2020
Merged
@FRidh FRidh merged commit d2971d1 into staging Jun 13, 2020
@FRidh FRidh mentioned this pull request Jun 13, 2020
Merged
10 tasks
simonchatts added a commit to simonchatts/nixpkgs that referenced this pull request Jun 19, 2020
@simonchatts
python: entrance: 1.1.12 -> 1.1.13
84ca991 
Required by the ujson update in NixOS#89723
@simonchatts simonchatts mentioned this pull request Jun 19, 2020
Merged
10 tasks
@meh
Copy link

meh commented Jun 19, 2020

This seems to have broken cheroot, the tests now fail.

FRidh pushed a commit that referenced this pull request Jun 20, 2020
@simonchatts @FRidh
python: entrance: 1.1.12 -> 1.1.13
3eea039 
Required by the ujson update in #89723
@nova-nowiz nova-nowiz mentioned this pull request Jul 1, 2020
Closed
@jpas jpas mentioned this pull request Jul 6, 2020
Closed
@infinisil infinisil mentioned this pull request Aug 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@FRidh @nixos-discourse @bhipple @jonringer @das-g @meh @emmanuelrosa