Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gore: init at 0.5.0 #89722

Merged
merged 1 commit into from Jun 10, 2020
Merged

gore: init at 0.5.0 #89722

merged 1 commit into from Jun 10, 2020

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

It's nice to have repl when developing in golang

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

[matt@servnerr-3:~/src/nixpkgs]$ nix-build -A gore
these derivations will be built:
  /nix/store/8fx4z2iwfq4pr0nprfs788ikygdfh3fr-source.drv
  /nix/store/84srx8cgqm1pr65hqznjm2bcwxnhd7s5-gore-0.5.0-go-modules.drv
  /nix/store/hgk94nkgcqf8hka49qc9pn8iknx8h3rq-gore-0.5.0.drv
...
shrinking /nix/store/mvhpg8553mgvvpsvvn6nsd86n6rsczbb-gore-0.5.0/bin/gore
strip is /nix/store/0x8pbk0578knfpxf9gbl0lhmpynh2947-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mvhpg8553mgvvpsvvn6nsd86n6rsczbb-gore-0.5.0/bin
patching script interpreter paths in /nix/store/mvhpg8553mgvvpsvvn6nsd86n6rsczbb-gore-0.5.0
checking for references to /build/ in /nix/store/mvhpg8553mgvvpsvvn6nsd86n6rsczbb-gore-0.5.0...
/nix/store/mvhpg8553mgvvpsvvn6nsd86n6rsczbb-gore-0.5.0

[matt@servnerr-3:~/src/nixpkgs]$ ./result/bin/gore
gore> :import fmt
gore> fmt.Println("hello world")
hello world
12
nil

@kalbasit
Copy link
Member

@GrahamcOfBorg build gore

@kalbasit kalbasit merged commit e8bcac7 into NixOS:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants