Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.sexplib_p4: remove #89727

Merged
merged 3 commits into from Jun 7, 2020
Merged

ocamlPackages.sexplib_p4: remove #89727

merged 3 commits into from Jun 7, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 7, 2020

Motivation for this change

These are legacy versions for OCaml ≤ 4.02.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vbgl added 3 commits June 7, 2020 10:15
@vbgl
ocamlPackages.sexplib_108_08_00: remove at 108.08.00
0cadf9c 
This is a legacy version for OCaml ≤ 4.02
@vbgl
ocamlPackages.sexplib_111_25_00: remove at 111.25.00
f4a7f9f 
This is a legacy version for OCaml ≤ 4.02
@vbgl
ocamlPackages.sexplib_112_24_01: remove at 112.24.01
cb6ffc1 
This is a legacy version for OCaml ≤ 4.02
@bhipple
Copy link
Contributor

bhipple commented Jun 7, 2020

Result of nixpkgs-review pr 89727 1

@bhipple bhipple merged commit c6a8c32 into NixOS:master Jun 7, 2020
@vbgl vbgl deleted the ocaml-sexplib-remove-legacy branch June 7, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @bhipple