Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/bitwarden_rs: add test #89729

Merged
merged 2 commits into from Aug 22, 2020
Merged

Conversation

JJJollyjim
Copy link
Member

Motivation for this change

The bitwarden ecosystem is currently untested in NixOS, and the server (bitwarden-rs) is somewhat important for those that rely on it.

This test provides coverage for all three database backends of bitwarden_rs, as well as bitwarden_rs-vault under Firefox and bitwarden-cli. The electron client bitwarden remains untested.

My original goal was to just use the cli, but it does not support account creation, so I ended up using webdriver to interact with the web UI. This approach is borrowed from nixos/tests/nginx-etag.nix. I expect that this will break at some point if the web UI is heavily modified -- I have added myself as maintainer to signal my intention to fix breakages.

As I note in a comment, the same tests should work without modification on the official bitwarden server, if we ever package that. (#51212).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JJJollyjim
Copy link
Member Author

@ofborg test bitwarden.sqlite bitwarden.mysql bitwarden.postgresql

@Lassulus
Copy link
Member

needs a rebase

@JJJollyjim
Copy link
Member Author

@Lassulus done

@JJJollyjim
Copy link
Member Author

@ofborg test bitwarden.sqlite bitwarden.mysql bitwarden.postgresql

@Lassulus Lassulus merged commit dd2ecd0 into NixOS:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants