micropro: init at 0.4 #89689

kaliumxyz · 2020-06-06T18:33:41Z

Motivation for this change

getting the Micropro TL866CS universal programmer utility in nixpkgs

Things done

Wrote nix file for micropro utility, added self as its maintainer.

IvarWithoutBones

Added a few suggestions :)

Also, commit message does not follow the contributing guidelines.

pkgs/development/tools/minipro/default.nix

kaliumxyz · 2020-06-09T06:17:10Z

@IvarWithoutBones I've incorporated your suggestions c:

IvarWithoutBones

Few more minor nits, otherwise LGTM :)

IvarWithoutBones · 2020-06-10T17:54:03Z

pkgs/development/tools/minipro/default.nix

+  ];
+
+  buildInputs = [
+    stdenv


Doesn't look like stdenv is required here.

IvarWithoutBones · 2020-06-10T17:55:03Z

pkgs/development/tools/minipro/default.nix

@@ -0,0 +1,46 @@
+{stdenv, fetchgit, pkg-config, libusb1}:


Minor formatting thing:

Suggested change

{stdenv, fetchgit, pkg-config, libusb1}:

{ stdenv, fetchgit, pkg-config, libusb1 }:

stdenv.mkDerivation rec {

IvarWithoutBones · 2020-06-10T17:57:00Z

pkgs/development/tools/minipro/default.nix

+  PKG_CONFIG = "${pkg-config}/bin/pkg-config";
+
+  buildPhase = ''
+    sed -i -e 's/        GIT_BRANCH = .*/        GIT_BRANCH = "master"/g' ./Makefile


The patching should probably be done in the preConfigure phase. Also, i think using substituteInPlace would be a bit cleaner than using sed.

IvarWithoutBones · 2020-06-10T18:10:29Z

pkgs/development/tools/minipro/default.nix

+  pname = "minipro";
+  version = "0.4";
+
+  src = fetchgit {


Apologies, missed this earlier. Should be using fetchFromGitLab here, this way you can fetch the stable release:

Suggested change

src = fetchgit {

src = fetchFromGitLab {

owner = "DavidGriffith";

repo = "minipro";

rev = version;

sha256 = "17k2vanz0xrmvl5sa12jr1n4x5m2s7292qs79mvj40bxbhrcmaci";

};

IvarWithoutBones · 2020-06-10T18:10:59Z

pkgs/development/tools/minipro/default.nix

+    cp -rv ./minipro $out/bin/
+    mkdir $outputMan -p
+    mv ./man/* $outputMan
+'';


This should be tabbed over once

kaliumxyz · 2020-06-11T20:13:38Z

@IvarWithoutBones I've split up the package in stable and unstable, moved to using leaveDotGit so that the package can be build as intended (which sadly does mean that we need to keep using fetchgit), fixed the manpages and the udev files, it should be good to go now c: Thank you for your help and feedback so far!

IvarWithoutBones · 2020-06-11T23:56:25Z

I've split up the package in stable and unstable

Why both? Wouldn't just stable be good enough?

moved to using leaveDotGit so that the package can be build as intended

That's probably not a very good idea, because of #8567 (Also, pretty sure fetchFromGitLab has a similar flag). From local testing i noticed the testing isn't required, couldn't we just drop it? (Assuming that's why you want to keep .git)

Thank you for your help and feedback so far!

Glad it's helpful :) Apologies about inconsistencies and such, I'm quite a beginner at this 😅

Also, looks like you forgot to push.

kaliumxyz · 2020-06-12T07:15:57Z

Why both? Wouldn't just stable be good enough?
The unstable variant has support for newer firmware (though not for the minipro I use), and some fixes

That's probably not a very good idea, because of #8567 (Also, pretty sure fetchFromGitLab has a similar flag). [...]
The .git is for version information, its not required but its part of the tool, I could not find a similar flag on fetchFromGitLab, seeing that its only used for version information and not part of the output, it should not lead to issues with the build being nondeterministic. I just realized that the build output includes a timestamp in the version, which should probably be patched out (let me do that quickly).

forgot to push
pushed now c:

IvarWithoutBones · 2020-06-12T07:31:38Z

The unstable variant has support for newer firmware (though not for the minipro I use), and some fixes

Ah, okay 👍

seeing that its only used for version information and not part of the output, it should not lead to issues with the build being nondeterministic

This is an issue in the cloning process, so it would.

kaliumxyz · 2020-06-12T07:35:29Z

we can go back to patching out the version information and just showing blanks on -V, setting it to anything else relevant, or manually setting it for every update (unless there is some other way we can get the information of the current commit?).

IvarWithoutBones

Few more nits :)

IvarWithoutBones · 2020-06-12T07:34:25Z

pkgs/development/tools/minipro/unstable.nix

+{ stdenv, installShellFiles, which, fetchgit, git, pkg-config, libusb1 }:
+stdenv.mkDerivation rec {
+  pname = "minipro";
+  version = "0.4dev";


Version naming convention for unstable git revs is unstable-<date>.

Suggested change

version = "0.4dev";

version = "unstable-2020-04-18";

IvarWithoutBones · 2020-06-12T07:38:20Z

pkgs/development/tools/minipro/unstable.nix

+    substituteInPlace Makefile --replace '$(shell date "+%Y-%m-%d %H:%M:%S %z")' "1970-01-01 00:00:00 +0000"
+  '';
+
+  buildPhase = ''


Could be using makeFlags for this.

Suggested change

buildPhase = ''

makeFlags = [ "-e minipro" ];

IvarWithoutBones · 2020-06-12T07:38:55Z

pkgs/development/tools/minipro/unstable.nix

+  ];
+
+  buildInputs = [
+    stdenv


stdenv doesn't seem to be required

IvarWithoutBones · 2020-06-12T07:39:38Z

pkgs/development/tools/minipro/unstable.nix

+    description = "An open source program for controlling the MiniPRO TL866xx series of chip programmers";
+    homepage = "https://gitlab.com/DavidGriffith/minipro";
+    maintainers = with maintainers; [ kalium ];
+    license = stdenv.lib.licenses.gpl3;


Since you're already doing with stdenv.lib;, you don't need to mention that here.

Suggested change

license = stdenv.lib.licenses.gpl3;

license = licenses.gpl3;

IvarWithoutBones · 2020-06-12T07:40:50Z

pkgs/development/tools/minipro/default.nix

@@ -0,0 +1,49 @@
+{ stdenv, installShellFiles, which, fetchgit, git, pkg-config, libusb1 }:


It doesn't look like you're using either git or which, and the package seems to compile fine without them.

IvarWithoutBones · 2020-06-12T07:48:30Z

we can go back to patching out the version information and just showing blanks on -V

I have a local expression which does none of the git patching, and doesn't have leaveDotGit enabled. However, it still outputs the following when executing it with the -V flag:

minipro version 0.4dev     A free and open TL866XX programmer
Build date:     2020-06-12 07:43:54 +0000
Commit date:    2019-10-19 23:38:37 +0000
Git commit:     5c397ebf4b5e736c31f4469821895bcc1bd38d69
Git branch:     tag: 0.4, refs/keep-around/5c397ebf4b5e736c31f4469821895bcc1bd38d69

I think we don't need to worry about that at all.

@IvarWithoutBones

minipro is a utility for using the minipro TL866 series of universal programmers corrected with suggestions from @IvarWithoutBones

kaliumxyz · 2020-06-12T08:18:54Z

okay good, seems to work for me as well now.

I've incorporated your comments, and only patch out the buildDate timestamp (else its not deterministic) :).

IvarWithoutBones

LGMT :)

Lassulus · 2020-08-22T12:34:51Z

We need a rebase because the maintainer-list got updated

stale · 2021-06-03T19:34:35Z

I marked this as stale due to inactivity. → More info

maintainers: add kalium

2f4b073

kaliumxyz changed the title ~~add Micropro~~ micropro: init at 0.4dev Jun 6, 2020

kaliumxyz changed the title ~~micropro: init at 0.4dev~~ micropro: init at 0.4 Jun 6, 2020

IvarWithoutBones reviewed Jun 7, 2020

View reviewed changes

kaliumxyz force-pushed the master branch from 35faa59 to 10152f2 Compare June 9, 2020 06:14

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 9, 2020

IvarWithoutBones reviewed Jun 10, 2020

View reviewed changes

kaliumxyz force-pushed the master branch from 10152f2 to 4749839 Compare June 12, 2020 07:14

ofborg bot removed the 10.rebuild-linux: 1 label Jun 12, 2020

kaliumxyz force-pushed the master branch from 4749839 to 8337cd0 Compare June 12, 2020 07:24

IvarWithoutBones reviewed Jun 12, 2020

View reviewed changes

micropro: init at 0.4

e46c68f

minipro is a utility for using the minipro TL866 series of universal programmers corrected with suggestions from @IvarWithoutBones

kaliumxyz force-pushed the master branch from 8337cd0 to e46c68f Compare June 12, 2020 08:16

IvarWithoutBones approved these changes Jun 12, 2020

View reviewed changes

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

ryantm added the 2.status: merge conflict label Oct 3, 2020

SuperSandro2000 marked this pull request as draft November 28, 2020 00:22

bmwalters mentioned this pull request May 12, 2021

minipro: init at 0.5 #121766

Merged

10 tasks

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021

Artturin closed this Feb 2, 2023

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

micropro: init at 0.4 #89689

micropro: init at 0.4 #89689

kaliumxyz commented Jun 6, 2020

IvarWithoutBones left a comment •

edited

kaliumxyz commented Jun 9, 2020

IvarWithoutBones left a comment

IvarWithoutBones Jun 10, 2020

IvarWithoutBones Jun 10, 2020 •

edited

IvarWithoutBones Jun 10, 2020

IvarWithoutBones Jun 10, 2020

IvarWithoutBones Jun 10, 2020

kaliumxyz commented Jun 11, 2020 •

edited

IvarWithoutBones commented Jun 11, 2020 •

edited

kaliumxyz commented Jun 12, 2020

IvarWithoutBones commented Jun 12, 2020

kaliumxyz commented Jun 12, 2020

IvarWithoutBones left a comment

IvarWithoutBones Jun 12, 2020

IvarWithoutBones Jun 12, 2020

IvarWithoutBones Jun 12, 2020

IvarWithoutBones Jun 12, 2020

IvarWithoutBones Jun 12, 2020

IvarWithoutBones commented Jun 12, 2020

kaliumxyz commented Jun 12, 2020

IvarWithoutBones left a comment

Lassulus commented Aug 22, 2020

stale bot commented Jun 3, 2021

-  src = fetchgit {
+  src = fetchFromGitLab {
+    owner = "DavidGriffith";
+    repo = "minipro";
+    rev = version;
+    sha256 = "17k2vanz0xrmvl5sa12jr1n4x5m2s7292qs79mvj40bxbhrcmaci";
+  };

		@@ -0,0 +1,49 @@
		{ stdenv, installShellFiles, which, fetchgit, git, pkg-config, libusb1 }:

micropro: init at 0.4 #89689

micropro: init at 0.4 #89689

Conversation

kaliumxyz commented Jun 6, 2020

Motivation for this change

Things done

IvarWithoutBones left a comment • edited

Choose a reason for hiding this comment

kaliumxyz commented Jun 9, 2020

IvarWithoutBones left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IvarWithoutBones Jun 10, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaliumxyz commented Jun 11, 2020 • edited

IvarWithoutBones commented Jun 11, 2020 • edited

kaliumxyz commented Jun 12, 2020

IvarWithoutBones commented Jun 12, 2020

kaliumxyz commented Jun 12, 2020

IvarWithoutBones left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IvarWithoutBones commented Jun 12, 2020

kaliumxyz commented Jun 12, 2020

IvarWithoutBones left a comment

Choose a reason for hiding this comment

Lassulus commented Aug 22, 2020

stale bot commented Jun 3, 2021

IvarWithoutBones left a comment •

edited

IvarWithoutBones Jun 10, 2020 •

edited

kaliumxyz commented Jun 11, 2020 •

edited

IvarWithoutBones commented Jun 11, 2020 •

edited