Release 20.03 #89776
Closed
Release 20.03 #89776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f5c0535)
https://github.com/cli/cli/releases/tag/v0.7.0 (cherry picked from commit f7b9c6c)
(cherry picked from commit 4755186)
(cherry picked from commit 024a6dc)
…port libfm: fix duplicate inclusion of libfm-extra
https://github.com/cli/cli/releases/tag/v0.8.0 (cherry picked from commit 6618edf)
When there is no .version-suffix file in nixpkgs (like when fetching nixpkgs with builtins.fetchGit), lib.version suffixes the version string with "pre-git". The "pre" bit is special cased in builtins.compareVersions which means "20.03pre-git" is interpreted as "less than 20.03". This is clearly wrong for the release-20.03 branch *after* the release has been made. Change the suffix to "post-git" to make code like this behave the same whether nixpkgs is fetched from git or the channel (which has .version-suffix file): lib.versionOlder lib.version "20.03" lib.versionAtLeast lib.version "20.03" (Currently the result depend on how nixpkgs was obtained!) This change should be made part of the release process.
https://github.com/yory8/clipman/releases/tag/v1.5.2 (cherry picked from commit ebeea74)
and ran nixpkgs-fmt. This allows to access visidata's help via ctrl+H. (cherry picked from commit d21cf30)
(cherry picked from commit b332947)
(cherry picked from commit 5e20609)
(cherry picked from commit 1619ec9)
(cherry picked from commit 4a5b853)
fixes CVE-2020-11054 (cherry picked from commit 52fcfd3)
Regression introduced by bce5268. The bit size of the initialisation vector for AES GCM has been introduced in NSS version 3.52 in the CK_GCM_PARMS struct via the ulIvBits field. Unfortunately, Firefox 68.8.0 and 76.0 do not set this field and thus it gets initialised to zero, which in turn causes IV generation to fail. I found out about this because WebRTC stopped working after updating to NSS 3.52 and so I started bisecting. Since there wasn't an obvious error in Firefox hinting towards NSS but instead just the video stream ended up as a "null" stream, I didn't suspect the NSS update to be the culprit at first. So I verified a few times and then also started bisecting the actual commit in NSS that caused the issue. This turned out to be the problematic change: https://phabricator.services.mozilla.com/D63241 > One notable change was caused by an inconsistancy between the spec and > the released headers in PKCS#11 v2.40. CK_GCM_PARAMS had an extra > field in the header that was not in the spec. OASIS considers the > header file to be normative, so PKCS#11 v3.0 resolved the issue in > favor of the header file definition. Since the test I've used[1] was a bit flaky, I still didn't believe the result of the bisect to be accurate, but after running the test several times leading same results I dug through the above change line by line to get more clues. It fortunately didn't take that long to stumble upon the ulIvBits change (which is actually documented in the NSS 3.52 release notes[4], but I managed to blatantly ignore it for some reason) and started checking the Firefox source tree for changes regarding that field. Initialisation of that new field has been introduced[2] in preparation for the 76 release, but subsequently got reverted[3] prior to the release, because Firefox 76 is expected to be shipped with NSS 3.51, which didn't have the ulIvBits field. The patch I'm adding here is just a reintroduction of that change, because we're using NSS 3.52. Not initialising that field will break WebRTC and WebCrypto, which I think the former seems to gain in popularity these days ;-) Tested the change against the mentioned VM test[1] and also by testing manually using Jitsi Meet and Nextcloud Talk. [1]: https://github.com/aszlig/avonc/tree/884315838b6f0ebb32b/tests/talk [2]: https://hg.mozilla.org/mozilla-central/rev/3ed30e6b6de1 [3]: https://hg.mozilla.org/mozilla-central/rev/665137da70ee [4]: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.52_release_notes Signed-off-by: aszlig <aszlig@nix.build> (cherry picked from commit 8fb4997 & moved to packages.nix)
…arwin backport: visidata is supported on darwin + add setuptools
[20.03] gitAndTools.gh: 0.6.4 -> 0.8.0
https://github.com/rootless-containers/slirp4netns/releases/tag/v0.4.4 (cherry picked from commit b4cf1c9)
backport: sane-airscan: 0.9.17 -> 0.99.0
(cherry picked from commit e9dbf2e)
(cherry picked from commit e3ba43b)
(cherry picked from commit 7ef8639)
paperdigits
requested review from
peti,
Profpatsch,
tfc,
thoughtpolice,
ttuegel and
WilliButz
as code owners
|
Wow, not what I wanted to do... |
ofborg
bot
added
6.topic: emacs
6.topic: fetch
6.topic: GNOME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
DisplayCal version 3.5 as released with NixOS 20.03 could not perform a calibration, but did compile. Updating to the latest stable release and fixing the packaging allows for a successful calibration.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)