Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when SDL2 provides SDL2Config #8198

Merged
merged 1 commit into from Jun 7, 2020
Merged

Error when SDL2 provides SDL2Config #8198

merged 1 commit into from Jun 7, 2020

Conversation

fsimonis
Copy link
Contributor

@fsimonis fsimonis commented Jun 7, 2020

This PR fixes a compilation error in case SDL2 provides a SDL2Config.cmake.
In the above case, the config provides the target SDL2::SDL2 which is ignored in the linking step.

@fsimonis fsimonis changed the title Fix: [CMake] Error when SDL2 provides SDL2Config Error when SDL2 provides SDL2Config Jun 7, 2020
glx22
glx22 approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsmh nielsmh merged commit 90e8491 into OpenTTD:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fsimonis @glx22 @nielsmh