Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polybar: Don't reference gcc #89716

Merged
merged 1 commit into from Jun 17, 2020
Merged

polybar: Don't reference gcc #89716

merged 1 commit into from Jun 17, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jun 7, 2020 •
edited

Polybar wants to be capable of printing the compiler that was used to
build it with polybar -vv but that makes it reference gcc. See:

https://github.com/polybar/polybar/blob/15e79b09d33c7cac888f93d218ae8be5ae617a2b/src/settings.cpp.cmake#L55

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
polybar: Don't reference gcc
b64ecc3 
Polybar wants to be capable of printing the compiler that was used to
build it with `polybar -vv` but that makes it reference gcc. See:

https://github.com/polybar/polybar/blob/15e79b09d33c7cac888f93d218ae8be5ae617a2b/src/settings.cpp.cmake#L55
@ofborg ofborg bot requested a review from Br1ght0ne June 7, 2020 06:30
@Lassulus Lassulus merged commit c847928 into NixOS:master Jun 17, 2020
@doronbehar doronbehar deleted the polybar-gcc-ref branch March 2, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @Lassulus