Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kurento-media-server: Init at 6.13.0 #89711

Closed
wants to merge 1 commit into from
Closed

kurento-media-server: Init at 6.13.0 #89711

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jun 7, 2020

Motivation for this change

#83072

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member Author

dasJ commented Jun 7, 2020

Additional note for anyone who reviews this: Kurento is an unholy abomination and the codebase is one of the worst I have packaged. For this reason, the nix expressions are a bit complicated as well.

@dasJ dasJ requested review from Lassulus, jluttine and jorsn June 17, 2020 17:07
@Lassulus
Copy link
Member

Lassulus commented Jun 18, 2020 •
edited

If you want to have this merged you need to maintain this. (or find someone who does :P)

@dasJ dasJ closed this Nov 21, 2020
@dasJ dasJ deleted the init/kurento branch November 21, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Awaiting requested review from Lassulus

@jluttine jluttine Awaiting requested review from jluttine

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasJ @Lassulus