autoPatchelfHook: add autoPatchelfIgnoreMissing #89718
Merged
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently autoPatchelfHook fails as soon as any dependency cannot be satisfied. But in some cases it is favorable to continue patching and ignore the missing dependencies. Some binary distributions contain optional features with their own dependencies. The current autoPatchelfHook forces you to patch all dependencies even if you know you will never use those features.
A specific example would be the python wheel distribution of Pytorch which contains files which depend on cuda, but in practice this dependency doesn't need to be satisfied if you don't plan to use cuda. (pytorch/pytorch#38624)
To solve this problem, I added the possibility to ignore missing dependencies by setting the environment variable
autoPatchelfIgnoreMissing
.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)