Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgraph: 1.0.17 -> 20.03.03 #89719

Closed
wants to merge 1 commit into from
Closed

dgraph: 1.0.17 -> 20.03.03 #89719

wants to merge 1 commit into from

Conversation

RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Jun 7, 2020 •
edited

Motivation for this change

Upgrade to the latest dgraph release

Note that although the version numbers jumped by 19 versions, dgraph changed their version scheme to follow <year>.<month>.<rev>, similar to NixOS.

Also transitions dgraph to buildGoModule

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from sigma and kalbasit June 7, 2020 07:34
@zowoq
Copy link
Contributor

zowoq commented Jun 7, 2020

Kind of a duplicate of #89642 except it's for 1.2.5.

@RaghavSood RaghavSood mentioned this pull request Jun 7, 2020
Merged
10 tasks
@RaghavSood
Copy link
Member Author

@zowoq Indeed, I just commented on that one too!

I think moving to 20.03.03 makes sense since it is the default version advertised by the installation docs on dgraph's website here

Alternatively, we could split into 1.2.5 as default and have 20.03.03 as dgraph_20_03, as many other multiversion packages do

@RaghavSood
Copy link
Member Author

Closing in favour of #89642

@RaghavSood RaghavSood closed this Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigma sigma Awaiting requested review from sigma

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RaghavSood @zowoq @Janik-Haag