New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.prometheus_flask_exporter: init at 0.15.4 #89720
Conversation
Result of 3 packages failed to build:- python27Packages.prometheus-flask-exporter - python37Packages.prometheus-flask-exporter - python38Packages.prometheus-flask-exporter |
pkgs/development/python-modules/prometheus-flask-exporter/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/prometheus-flask-exporter/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/prometheus-flask-exporter/default.nix
Outdated
Show resolved
Hide resolved
bump @nphilou |
Sorry for the delay, will try to fix it this week |
9254221
to
40e0a3c
Compare
40e0a3c
to
450cb36
Compare
propagatedBuildInputs = [ | ||
flask prometheus_client | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.
If tests are not available, then please use pythonImportsCheck
to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.
----------------------------------------------------------------------
Ran 0 tests in 0.000s
I don't need this package anymore, I'm closing this PR. Don't hesitate to reopen if needed. |
Add prometheus-flask-exporter python package
Motivation for this change
This package is required to update mlflow to last version
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)