Fix: Silence some warnings when building with clang-cl on VS 2019 #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang-cl presents as both _MSC_VER and __clang__ in the preprocessor which makes some things confusing.
nielsmh
force-pushed
the
clang-cl-warnings
branch
from
a29a2ad
to
a84fcb3
Compare
frosch123
reviewed
Jun 6, 2020
| @@ -198,7 +204,11 @@ | |||
|
|
|||
| #define CDECL _cdecl | |||
| #define WARN_FORMAT(string, args) | |||
| #define FINAL sealed | |||
| # ifndef __clang__ | |||
| # define FINAL sealed | |||
There was a problem hiding this comment.
Why do we still need this? "final" is C++11
LordAro
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang-cl presents as both
_MSC_VERand__clang__in the preprocessor which makes some things confusing.It was somewhat difficult to get it building with clang-cl, in particular making vcpkg behave, and I don't exactly remember what I did. This will need to be documented at some point, as I think I remember testing the clang-cl build to be measurably faster than the Microsoft compiler build.