Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borgbackup: 1.1.11 -> 1.1.13 #89680

Merged
merged 1 commit into from Jun 7, 2020
Merged

borgbackup: 1.1.11 -> 1.1.13 #89680

merged 1 commit into from Jun 7, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jun 6, 2020 •
edited

Motivation for this change

New upstream releases:

Marked broken on Python 3.8 due to an upstream issue that is currently
under investigation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli @dotlambda @globin

@mweinelt mweinelt mentioned this pull request Jun 6, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from dotlambda, globin and flokli June 6, 2020 17:52
@mweinelt mweinelt changed the title borgbackup: 1.1.11 -> 1.1.12 borgbackup: 1.1.11 -> 1.1.13 Jun 6, 2020
@ofborg ofborg bot requested a review from flokli June 6, 2020 23:26
@Ma27 Ma27 merged commit 1ea60ca into NixOS:master Jun 7, 2020
@mweinelt mweinelt deleted the borgbackup branch June 7, 2020 21:13
@dotlambda
Copy link
Member

Why don't we fetch the source instead of the release tarball and cythonize ourselves?

@flokli
Copy link
Contributor

flokli commented Jun 8, 2020

Why don't we fetch the source instead of the release tarball and cythonize ourselves?

I'm not sure what this will solve? We usually fetch from PyPI if there's a usable sdist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @dotlambda @flokli @Ma27