Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake always export compile commands #8199

Merged
merged 1 commit into from Jun 12, 2020
Merged

CMake always export compile commands #8199

merged 1 commit into from Jun 12, 2020

Conversation

fsimonis
Copy link
Contributor

@fsimonis fsimonis commented Jun 7, 2020 •
edited

This PR changes CMake to always export the compile commands.
This has no downsides and simplifies the use of tools such as clang-tidy or Sourcetrail.

glx22
glx22 approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@glx22 glx22 merged commit fb7723a into OpenTTD:master Jun 12, 2020
freprec pushed a commit to freprec/OpenTTD that referenced this pull request Jun 19, 2020
@fsimonis @freprec
Add: [CMake] Always export compile commands (OpenTTD#8199)
84eb9bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fsimonis @glx22