Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-toml: init at 1.8.0 #89706

Merged
merged 1 commit into from Jun 8, 2020
Merged

go-toml: init at 1.8.0 #89706

merged 1 commit into from Jun 8, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 6, 2020

Motivation for this change

Add https://github.com/pelletier/go-toml

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why not use buildGoModule?

@marsam
Copy link
Contributor Author

marsam commented Jun 8, 2020

why not use buildGoModule?

no special reason, I'm just inclined to use buildGoPackage when upstream vendorizes its dependencies

@marsam marsam merged commit 524e24c into NixOS:master Jun 8, 2020
@marsam marsam deleted the init-go-toml branch June 8, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants