Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Gnome and Pantheon: install nixos wallpapers #89763

Merged
merged 5 commits into from Jun 17, 2020
Merged

[20.03] Gnome and Pantheon: install nixos wallpapers #89763

merged 5 commits into from Jun 17, 2020

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Backports #86163

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace and others added 4 commits June 7, 2020 14:48
@worldofpeace
nixos-artwork: add file path attributes
392b8bc 
This makes things so much easier, and we install to
the path that both gnome-backgrounds and
elementary-wallpapers install to.

(cherry picked from commit 62587f4)
@jtojnar @worldofpeace
nixos/lightdm: change background type to path
20bfce5 
(cherry picked from commit 3d1706c)
@worldofpeace
nixos/gnome3: install nixos wallpapers
489ebe4 
(cherry picked from commit 7f3bc5b)
@worldofpeace
nixos/pantheon: install nixos wallpaper
b2bd937 
Fixes  NixOS#86146

(cherry picked from commit 5100e4f)
@worldofpeace worldofpeace requested a review from a team June 7, 2020 18:50
@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg test gnome3 pantheon

@worldofpeace worldofpeace merged commit efe40ce into NixOS:release-20.03 Jun 17, 2020
@worldofpeace worldofpeace deleted the backport-86163- branch June 17, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @jtojnar @alex-giusi-tiri @zowoq