Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nextcloud: preserve OC_PASS env variable in the occ wrapper #89762

Merged
merged 1 commit into from Jun 8, 2020

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Jun 7, 2020

The OC_PASS environment variable can be used to create a user with
occ user:add --password-from-env. It is currently not possible to
use the nextcloud-occ to "non-interactively" create a user since
this variable is ignored by sudo.

Note I plan to backport this to 20.03.

cc @Ma27

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The OC_PASS environment variable can be used to create a user with
`occ user:add --password-from-env`. It is currently not possible to
use the `nextcloud-occ` to "non-interactively" create a user since
this variable is ignored by sudo.
@Ma27
Copy link
Member

Ma27 commented Jun 7, 2020

@GrahamcOfBorg test nextcloud

@flokli flokli merged commit b56c66e into NixOS:master Jun 8, 2020
@nlewo
Copy link
Member Author

nlewo commented Jun 8, 2020

Backported to 20.03 in 4340dd7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants