Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Minor changes in bundle generation #8203

Merged
merged 4 commits into from Jun 8, 2020
Merged

Fix: Minor changes in bundle generation #8203

merged 4 commits into from Jun 8, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jun 7, 2020

With cmake merge, and the first successful nightly build run, I noticed some differences in the generated packages.
Before cmake

changelog.txt
openttd-20200604-master-gcdd2892c49-docs-ai.tar.xz
openttd-20200604-master-gcdd2892c49-docs-gs.tar.xz
openttd-20200604-master-gcdd2892c49-docs.tar.xz
openttd-20200604-master-gcdd2892c49-macosx.dmg
openttd-20200604-master-gcdd2892c49-macosx.zip
openttd-20200604-master-gcdd2892c49-source.tar.xz
openttd-20200604-master-gcdd2892c49-source.zip
openttd-20200604-master-gcdd2892c49-windows-win32.pdb.xz
openttd-20200604-master-gcdd2892c49-windows-win32.zip
openttd-20200604-master-gcdd2892c49-windows-win64.pdb.xz
openttd-20200604-master-gcdd2892c49-windows-win64.zip
README.md
released.txt
manifest.yaml

After cmake

changelog.txt
openttd-20200606-master-gb145ee310c-docs-ai.tar.xz
openttd-20200606-master-gb145ee310c-docs-gs.tar.xz
openttd-20200606-master-gb145ee310c-docs.tar.xz
openttd-20200606-master-gb145ee310c-macosx.dmg
openttd-20200606-master-gb145ee310c-source.tar.xz
openttd-20200606-master-gb145ee310c-source.zip
openttd-20200606-master-gb145ee310c-windows-win32.exe
openttd-20200606-master-gb145ee310c-windows-win32.pdb
openttd-20200606-master-gb145ee310c-windows-win32.zip
openttd-20200606-master-gb145ee310c-windows-win64.exe
openttd-20200606-master-gb145ee310c-windows-win64.pdb
openttd-20200606-master-gb145ee310c-windows-win64.zip
README.md
released.txt
manifest.yaml

This PR should generate the same packages as before cmake merge.

LordAro
LordAro previously approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@LordAro LordAro merged commit 0b86bd8 into OpenTTD:master Jun 8, 2020
@glx22 glx22 deleted the packages branch June 8, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @LordAro