Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moosefs: fix datapath for mfscgiserv #89740

Merged
merged 1 commit into from Jun 8, 2020
Merged

moosefs: fix datapath for mfscgiserv #89740

merged 1 commit into from Jun 8, 2020

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Jun 7, 2020 •
edited

Motivation for this change

The datapath in mfscgisrv is hardcoded and pointed to the nix store, which made the program fail on startup. This patch fixes the problem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
moosefs: fix datapath for mfscgiserv
69a601c 
The datapath in mfscgisrv is hardcoded and pointed to
the nix store, which made the program fail on startup.
@markuskowa markuskowa requested a review from mfossen June 7, 2020 13:36
@markuskowa markuskowa added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 7, 2020
mfossen
mfossen approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@mfossen mfossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@markuskowa markuskowa merged commit 9ebc144 into NixOS:master Jun 8, 2020
@markuskowa
Copy link
Member Author

back ported to 20.03 in b6042f5

@markuskowa markuskowa deleted the fix-moosefs branch June 8, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfossen mfossen mfossen approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @mfossen