Fix: Adjust .gitignore to CMake build system. #8196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Jun 7, 2020
|
|
||
| bundle/* | ||
| bundles/* | ||
| /.vs |
There was a problem hiding this comment.
We've never allowed editor-specific ignores in the past, why this one?
There was a problem hiding this comment.
It was project/.vs in previous .gitignore, and we support Visual Studio. And my other addition is also a VS specific one.
There was a problem hiding this comment.
Well yes, but by that definition we (now) support everything that cmake can generate. Unless .vs is produced when cmake is run, it shouldn't be there
LordAro
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.