Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantalaimon: fix build #89694

Merged
merged 3 commits into from Jun 20, 2020
Merged

pantalaimon: fix build #89694

merged 3 commits into from Jun 20, 2020

Conversation

symphorien
Copy link
Member

Motivation for this change

pantalaimon does not build on nixos-unstable

Some updates were needed. peewee tests now require psycopg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from simonchatts, Valodim and lovek323 June 6, 2020 20:30
@FRidh FRidh self-assigned this Jun 13, 2020
@FRidh
Copy link
Member

FRidh commented Jun 13, 2020

many package updates are now in #89723. Best rebase this on staging-next once those updates land there.

@ofborg ofborg bot requested review from rvl and dotlambda June 15, 2020 19:36
@symphorien symphorien changed the base branch from master to staging-next June 15, 2020 20:07
@symphorien
Copy link
Member Author

rebased on staging-next. I don't know why some r-ryantm and others commits are here, though.

@ofborg ofborg bot requested a review from dotlambda June 16, 2020 10:52
simonchatts
simonchatts approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@simonchatts simonchatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that this works with my dependencies on janus.

@symphorien
python3Packages.peewee: 3.11.2 -> 3.13.3
45fc638 
tests don't pass without psycopg2 support:
Exception: Your version of psycopg2 does not support JSON.
@symphorien
pantalaimon: 0.6.1 -> 0.6.3
6169bc2
@symphorien
python3Packages.aioresponses: disable test requiring networking
b6905d6
@symphorien symphorien changed the base branch from staging-next to master June 20, 2020 10:11
@symphorien
Copy link
Member Author

rebased on master, tested that pantalaimon builds and run.

This was referenced Jun 20, 2020
Merged
Merged
jonringer
jonringer approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nixpkgs-review freezing on python38Packages.uvloop, failures don't seem to be associated to any of these bumps

@jonringer jonringer merged commit dee5584 into NixOS:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@simonchatts simonchatts simonchatts approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@Valodim Valodim Awaiting requested review from Valodim

@lovek323 lovek323 Awaiting requested review from lovek323

@rvl rvl Awaiting requested review from rvl

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@symphorien @FRidh @dotlambda @jonringer @simonchatts