Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocrmypdf: 9.8.0 -> 9.8.2 #89710

Merged
merged 1 commit into from Jun 8, 2020
Merged

ocrmypdf: 9.8.0 -> 9.8.2 #89710

merged 1 commit into from Jun 8, 2020

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Jun 7, 2020

version bump also fixes build after pikepdf update:
#88680

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kiwi
ocrmypdf: 9.8.0 -> 9.8.2
96bfdf2 
version bump also fixes build after pikepdf update:
NixOS#88680
@evils
Copy link
Member

evils commented Jun 7, 2020 •
edited

builds and works for me

nixpkgs-review 
1 package built:
ocrmypdf
though many tests fail in not a lot of time (with doCheck = true; set) 
= 105 failed, 134 passed, 29 skipped, 8 deselected, 1 xfailed in 240.64s (0:04:00) =
builder for '/nix/store/a2nd36bfdnfhx5glk8hymrrv2pyvmbmw-ocrmypdf-9.8.2.drv' failed with exit code 1
error: build of '/nix/store/a2nd36bfdnfhx5glk8hymrrv2pyvmbmw-ocrmypdf-9.8.2.drv' failed
nix-build -A ocrmypdf  0.43s user 0.11s system 0% cpu 4:04.21 total
short test summary 
----------------------------- Captured stderr call -----------------------------
Scan: 100%|██████████| 1/1 [00:00<00:00, 360.89page/s]
OCR:   0%|          | 0.0/1.0 [00:00<?, ?page/s]
------------------------------ Captured log call -------------------------------
INFO     ocrmypdf:_sync.py:253 Using Tesseract OpenMP thread limit 3
=========================== short test summary info ============================
FAILED tests/test_acroform.py::test_acroform_message - FileNotFoundError: [Er...
FAILED tests/test_ghostscript.py::test_ghostscript_feature_elision - FileNotF...
FAILED tests/test_image_input.py::test_image_to_pdf - FileNotFoundError: [Err...
FAILED tests/test_image_input.py::test_jpeg_in_jpeg_out - FileNotFoundError: ...
FAILED tests/test_main.py::test_quick - FileNotFoundError: [Errno 2] No such ...
FAILED tests/test_main.py::test_oversample[hocr] - FileNotFoundError: [Errno ...
FAILED tests/test_main.py::test_oversample[sandwich] - FileNotFoundError: [Er...
FAILED tests/test_main.py::test_force_ocr - FileNotFoundError: [Errno 2] No s...
FAILED tests/test_main.py::test_argsfile - FileNotFoundError: [Errno 2] No su...
FAILED tests/test_main.py::test_maximum_options[pdf-hocr] - FileNotFoundError...
FAILED tests/test_main.py::test_maximum_options[pdf-sandwich] - FileNotFoundE...
FAILED tests/test_main.py::test_maximum_options[pdfa-hocr] - FileNotFoundErro...
FAILED tests/test_main.py::test_maximum_options[pdfa-sandwich] - FileNotFound...
FAILED tests/test_main.py::test_german - FileNotFoundError: [Errno 2] No such...
FAILED tests/test_main.py::test_missing_docinfo - assert <ExitCode.other_erro...
FAILED tests/test_main.py::test_uppercase_extension - FileNotFoundError: [Err...
FAILED tests/test_main.py::test_pagesegmode[hocr] - FileNotFoundError: [Errno...
FAILED tests/test_main.py::test_pagesegmode[sandwich] - FileNotFoundError: [E...
FAILED tests/test_main.py::test_algo4 - AssertionError: assert 1 == <ExitCode...
FAILED tests/test_main.py::test_jbig2_passthrough - FileNotFoundError: [Errno...
FAILED tests/test_main.py::test_masks - FileNotFoundError: [Errno 2] No such ...
FAILED tests/test_main.py::test_linearized_pdf_and_indirect_object - FileNotF...
FAILED tests/test_main.py::test_very_high_dpi - FileNotFoundError: [Errno 2] ...
FAILED tests/test_main.py::test_destination_not_writable - AssertionError: Ex...
FAILED tests/test_main.py::test_form_xobject - FileNotFoundError: [Errno 2] N...
FAILED tests/test_main.py::test_skip_big_with_no_images - FileNotFoundError: ...
FAILED tests/test_main.py::test_no_contents - FileNotFoundError: [Errno 2] No...
FAILED tests/test_main.py::test_compression_preserved[baiona.png] - Assertion...
FAILED tests/test_main.py::test_compression_preserved[baiona_gray.png] - Asse...
FAILED tests/test_main.py::test_compression_preserved[baiona_alpha.png] - ass...
FAILED tests/test_main.py::test_compression_preserved[congress.jpg] - Asserti...
FAILED tests/test_main.py::test_compression_changed[baiona.png-jpeg] - Assert...
FAILED tests/test_main.py::test_compression_changed[baiona_gray.png-lossless]
FAILED tests/test_main.py::test_compression_changed[congress.jpg-lossless] - ...
FAILED tests/test_main.py::test_sidecar_pagecount - FileNotFoundError: [Errno...
FAILED tests/test_main.py::test_sidecar_nonempty - FileNotFoundError: [Errno ...
FAILED tests/test_main.py::test_pdfa_n[1] - FileNotFoundError: [Errno 2] No s...
FAILED tests/test_main.py::test_pdfa_n[2] - FileNotFoundError: [Errno 2] No s...
FAILED tests/test_main.py::test_pdfa_n[3] - FileNotFoundError: [Errno 2] No s...
FAILED tests/test_main.py::test_text_curves - FileNotFoundError: [Errno 2] No...
FAILED tests/test_main.py::test_output_is_dir - AssertionError: assert 1 == <...
FAILED tests/test_main.py::test_output_is_symlink - AssertionError: Traceback...
FAILED tests/test_main.py::test_fast_web_view[1.0-0-pdfa-False] - FileNotFoun...
FAILED tests/test_main.py::test_fast_web_view[1.0-0-pdf-False] - FileNotFound...
FAILED tests/test_main.py::test_fast_web_view[0.0-0-pdfa-True] - FileNotFound...
FAILED tests/test_main.py::test_fast_web_view[0.0-0-pdf-True] - FileNotFoundE...
FAILED tests/test_main.py::test_fast_web_view[1.0-1-pdfa-False] - FileNotFoun...
FAILED tests/test_main.py::test_fast_web_view[1.0-1-pdf-False] - FileNotFound...
FAILED tests/test_main.py::test_fast_web_view[0.0-1-pdfa-True] - FileNotFound...
FAILED tests/test_main.py::test_fast_web_view[0.0-1-pdf-True] - FileNotFoundE...
FAILED tests/test_main.py::test_image_dpi_not_image - FileNotFoundError: [Err...
FAILED tests/test_metadata.py::test_preserve_metadata[pdfa] - FileNotFoundErr...
FAILED tests/test_metadata.py::test_preserve_metadata[pdf] - FileNotFoundErro...
FAILED tests/test_metadata.py::test_override_metadata[pdfa] - AssertionError:...
FAILED tests/test_metadata.py::test_override_metadata[pdf] - AssertionError: ...
FAILED tests/test_metadata.py::test_creation_date_preserved[pdf-trivial.pdf]
FAILED tests/test_metadata.py::test_creation_date_preserved[pdf-jbig2.pdf] - ...
FAILED tests/test_metadata.py::test_creation_date_preserved[pdfa-trivial.pdf]
FAILED tests/test_metadata.py::test_creation_date_preserved[pdfa-jbig2.pdf]
FAILED tests/test_metadata.py::test_xml_metadata_preserved[pdf] - FileNotFoun...
FAILED tests/test_metadata.py::test_xml_metadata_preserved[pdfa] - FileNotFou...
FAILED tests/test_metadata.py::test_kodak_toc - FileNotFoundError: [Errno 2] ...
FAILED tests/test_optimize.py::test_jpg_png_params - FileNotFoundError: [Errn...
FAILED tests/test_optimize.py::test_jbig2_lossy[False] - FileNotFoundError: [...
FAILED tests/test_optimize.py::test_jbig2_lossy[True] - FileNotFoundError: [E...
FAILED tests/test_optimize.py::test_flate_to_jbig2 - FileNotFoundError: [Errn...
FAILED tests/test_optimize.py::test_multiple_pngs - FileNotFoundError: [Errno...
FAILED tests/test_page_numbers.py::test_limited_pages - FileNotFoundError: [E...
FAILED tests/test_preprocessing.py::test_deskew - FileNotFoundError: [Errno 2...
FAILED tests/test_preprocessing.py::test_remove_background - FileNotFoundErro...
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-sandwich-palette.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-sandwich-cmyk.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-sandwich-ccitt.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-sandwich-jbig2.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-sandwich-lichtenstein.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-hocr-palette.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-hocr-cmyk.pdf] - Fi...
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-hocr-ccitt.pdf] - F...
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-hocr-jbig2.pdf] - F...
FAILED tests/test_preprocessing.py::test_exotic_image[pdf-hocr-lichtenstein.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-sandwich-palette.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-sandwich-cmyk.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-sandwich-ccitt.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-sandwich-jbig2.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-sandwich-lichtenstein.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-hocr-palette.pdf]
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-hocr-cmyk.pdf] - F...
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-hocr-ccitt.pdf] - ...
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-hocr-jbig2.pdf] - ...
FAILED tests/test_preprocessing.py::test_exotic_image[pdfa-hocr-lichtenstein.pdf]
FAILED tests/test_preprocessing.py::test_non_square_resolution[hocr] - FileNo...
FAILED tests/test_preprocessing.py::test_non_square_resolution[sandwich] - Fi...
FAILED tests/test_preprocessing.py::test_convert_to_square_resolution[hocr]
FAILED tests/test_preprocessing.py::test_convert_to_square_resolution[sandwich]
FAILED tests/test_rotation.py::test_autorotate_threshold[1-correlation > 0.80]
FAILED tests/test_rotation.py::test_autorotate_threshold[99-correlation < 0.10]
FAILED tests/test_stdio.py::test_stdin - AssertionError: assert 1 == <ExitCod...
FAILED tests/test_stdio.py::test_stdout - AssertionError: assert 1 == <ExitCo...
FAILED tests/test_stdio.py::test_dev_null - AssertionError: could not send ou...
FAILED tests/test_unpaper.py::test_clean - FileNotFoundError: [Errno 2] No su...
FAILED tests/test_unpaper.py::test_unpaper_args_valid - FileNotFoundError: [E...
FAILED tests/test_unpaper.py::test_unpaper_args_invalid_filename - assert 'No...
FAILED tests/test_unpaper.py::test_unpaper_args_invalid - AssertionError: ass...
FAILED tests/test_userunit.py::test_userunit_qpdf_passes - FileNotFoundError:...
FAILED tests/test_userunit.py::test_rotate_interaction - FileNotFoundError: [...

@Kiwi Kiwi requested review from jonringer and flokli June 7, 2020 20:44
@flokli
Copy link
Contributor

flokli commented Jun 8, 2020

Humm… I'm a bit worried about the tests being disabled. We won't spot breakages (in fact, this already regressed in 20.03), and should better have tests enabled by default.

Chromium takes hours to build, so enabling tests here (once we get them to work) seems to be a no-brainer. Also note it only took my machine ~2mins to fail :-)

The failures all seem to be due to the check_ocrmypdf pytest helper not finding tesseract. Error output on 20.03 looks similar.

As it just invokes api.run_pipeline(options, api=True), this might be a real breakage - maybe we also just need to provide tesserract in $PATH before executing the tests, not sure.

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2020

Result of nixpkgs-review pr 89710 1

1 package built:
- ocrmypdf

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2020

The tests are already disabled and the update is working for me.
Leave enabling the tests to a future pr.

@Mic92 Mic92 merged commit d07a490 into NixOS:master Jun 8, 2020
@bachp bachp mentioned this pull request Jul 9, 2020
Merged
10 tasks
@Kiwi Kiwi deleted the ocrmypdf-9.8.2 branch August 19, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kiwi @evils @flokli @Mic92