Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luxcorerender: dependency: python35 -> python36 #89755

Merged
merged 1 commit into from Jun 15, 2020
Merged

luxcorerender: dependency: python35 -> python36 #89755

merged 1 commit into from Jun 15, 2020

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Jun 7, 2020

Motivation for this change

This should remove the last dependency on Python 3.5 in nixpkgs. Using newer Python versions would require a more invasive modification.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wamserma
Copy link
Member Author

wamserma commented Jun 7, 2020

@Hodapp87 please test and consider updating to 2.3 with a follow-up PR.

# v2.3 has unpackaged dependencies, e.g. Intel Open Image Denoiser
# hash for v2.3
sha256 = "1wlyjf5jsl6qzlgnqwjccacq64c8cg852flqqabhbqv9hasqacr5";

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/upcoming-python-breakage/7554/3

@ofborg ofborg bot requested a review from Hodapp87 June 7, 2020 17:54
@wamserma wamserma mentioned this pull request Jun 8, 2020
Closed
10 tasks
Hodapp87
Hodapp87 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@Hodapp87 Hodapp87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test render works fine.

@Hodapp87
Copy link
Contributor

Hodapp87 commented Jun 8, 2020

@wamserma Thank you. I'll try to work on that soon.

@wamserma
Copy link
Member Author

@FRidh merge?

@Mic92 Mic92 merged commit 9dcda45 into NixOS:master Jun 15, 2020
@wamserma wamserma deleted the luxcorerender-py36 branch June 16, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hodapp87 Hodapp87 Hodapp87 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wamserma @nixos-discourse @Hodapp87 @Mic92