Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nym: 0.6.0 -> 0.7.0 #89766

Merged
merged 2 commits into from Jun 8, 2020
Merged

nym: 0.6.0 -> 0.7.0 #89766

merged 2 commits into from Jun 8, 2020

Conversation

hyperfekt
Copy link
Contributor

I haven't actually tested compilation of arm (my computer apparently can't take compiling rustc...), or execution on anything but x86 NixOS.

I had to fix Rust cross-compilation for aarch64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hyperfekt hyperfekt requested a review from andir as a code owner June 7, 2020 19:53
@ofborg ofborg bot requested a review from ehmry June 7, 2020 20:01
@ehmry ehmry merged commit 5ac6f22 into NixOS:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: rust 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hyperfekt @ehmry