Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watson: 1.8.0 -> 1.9.0 #89764

Merged
merged 1 commit into from Jun 8, 2020
Merged

watson: 1.8.0 -> 1.9.0 #89764

merged 1 commit into from Jun 8, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jun 7, 2020

Motivation for this change

Update Watson to its latest release.

The src was switched to GitHub because PyPi does not contain all the
necessary test artefacts. Furthermore, a custom patch to support the
latest arrow version was added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxzi
watson: 1.8.0 -> 1.9.0
1e3559f 
The src was switched to GitHub because PyPi does not contain all the
necessary test artefacts. Furthermore, a custom patch to support the
latest arrow version was added.
@ofborg ofborg bot requested review from mguentner and nathyong June 7, 2020 19:24
@marsam marsam merged commit e3a8626 into NixOS:master Jun 8, 2020
@oxzi oxzi deleted the watson-1.9.0 branch June 8, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguentner mguentner Awaiting requested review from mguentner

@nathyong nathyong Awaiting requested review from nathyong

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxzi @marsam