Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle lists "Manage list" options inconsistent #8206

Closed
SHADOW-XIII opened this issue Jun 7, 2020 · 3 comments
Closed

Vehicle lists "Manage list" options inconsistent #8206

SHADOW-XIII opened this issue Jun 7, 2020 · 3 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! good first issue Good for newcomers

Comments

@SHADOW-XIII
Copy link

SHADOW-XIII commented Jun 7, 2020

Version of OpenTTD

1.10.2

Expected result

"Manage list" option should give possibility to replace vehicles and possibly option to save all vehicles to a new list

Actual result

"Manage list" option in "Station vehicles" list is fairly limited
"Manage list" option in "Shared orders" list also limited as above

Steps to reproduce

It's possibly a feature request but vehicle lists are inconsistent depending how they are open.

When opening a station window, there's button on the bottom to open all vehicles that use this station, ie. all trains, all road vehicles etc. It shows a new window with a list of those vehicles and button (drop down) with "Send for Servicing" and "Send to Depot".
The vehicles list showing "Shared Orders" vehicles (accessible from Orders window, with small button on the right) is also limited same as "Station vehicles" list

The "Manage List" options should be expanded, ie. to "Save as a new vehicle list" and "Replace vehicles" (like in a Vehicles list (accessible from the top/menu button).

image

image

@SHADOW-XIII
Copy link
Author

as per discord chat, adding vehicles to a new group might have been done in: JGRennison/OpenTTD-patches@ca9f641

not sure about "Replace vehicles" option

@LordAro LordAro added the enhancement Issue would be a good enhancement; we accept Pull Requests! label Feb 21, 2021
@danuker
Copy link

danuker commented Jun 1, 2021

I agree that replacing vehicles from the "Shared orders" or from a station list would be very useful in-game.

This is because, when upgrading trains to a dual-headed locomotive, I want to see the trains that would fit in my newly-expanded stations.

If this is difficult to program due to the dynamic nature of the orders, I would also appreciate a "create group" option, to make the list of vehicles static.

@2TallTyler 2TallTyler added the good first issue Good for newcomers label Dec 29, 2022
@2TallTyler
Copy link
Member

Replacing vehicles from shared orders isn't possible because autoreplace can only be done for actual groups, that you can see in the groups menu. I think allowing this for implicit groups that don't show up in the groups menu would be confusing, since you couldn't easily find it -- in the groups menu, groups with autoreplace enabled have an icon. Outside that, you'd have to find the right vehicle or remember what station contained the list...which sounds like a nightmare to me.

That said, #10890 added a dropdown option to create a new group from an implicit group, which was one of the requested features and will make the desired action much easier. As such, I am going to close this issue. As always, if someone disagrees, feel free to re-open. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests! good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants