New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caster-soundboard: init at unstable-2019-9-28 #89714
Conversation
gst_all_1.gst-plugins-base | ||
gst_all_1.gst-plugins-good | ||
gst_all_1.gst-plugins-bad | ||
gst_all_1.gst-plugins-ugly | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should also need gst_all_1.gstreamer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also qtbase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first time submitting any PRs to nixpkgs. I'm sorry for getting a lot of the little formatting details slightly wrong. I'll try to do better in the future. All in all, I think these changes are acceptable, and should be made to the commits I've already done.
Cool, this means you'll supply the changes in the coming day/s? |
@worldofpeace I wasn't aware that I had to supply the changes myself, I thought that anyone with push access to the repo could make the changes for me. Sorry about that. I'll get on this right away. |
I marked this as stale due to inactivity. → More info |
@@ -8869,4 +8869,10 @@ | |||
github = "cpcloud"; | |||
githubId = 417981; | |||
}; | |||
iqubic = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be sorted alphabetical
enableParallelBuilding = true; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enableParallelBuilding = true; |
done by qmake
The project looks abandoned. No commit since Sep 28, 2019. |
Will close the pr since the project is almost definitively stale. |
Motivation for this change
caster-soundboard is a great application, and I noticed it wasn't in nixpkgs, so I packaged it up.
Things done
Added a derivation for caster-soundboard in pkg/audio
Added caster-soundboard to all-packages.nix
Added iqubic to the maintainers
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)