Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caster-soundboard: init at unstable-2019-9-28 #89714

Closed
wants to merge 3 commits into from
Closed

Conversation

IQubic
Copy link

@IQubic IQubic commented Jun 7, 2020

Motivation for this change

caster-soundboard is a great application, and I noticed it wasn't in nixpkgs, so I packaged it up.

Things done

Added a derivation for caster-soundboard in pkg/audio
Added caster-soundboard to all-packages.nix
Added iqubic to the maintainers

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines +17 to +21
gst_all_1.gst-plugins-base
gst_all_1.gst-plugins-good
gst_all_1.gst-plugins-bad
gst_all_1.gst-plugins-ugly
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should also need gst_all_1.gstreamer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also qtbase

pkgs/applications/audio/caster-soundboard/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/caster-soundboard/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/caster-soundboard/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/caster-soundboard/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/caster-soundboard/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/caster-soundboard/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/caster-soundboard/default.nix Outdated Show resolved Hide resolved
Copy link
Author

@IQubic IQubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time submitting any PRs to nixpkgs. I'm sorry for getting a lot of the little formatting details slightly wrong. I'll try to do better in the future. All in all, I think these changes are acceptable, and should be made to the commits I've already done.

@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 18, 2020

This is my first time submitting any PRs to nixpkgs. I'm sorry for getting a lot of the little formatting details slightly wrong. I'll try to do better in the future. All in all, I think these changes are acceptable, and should be made to the commits I've already done.

Cool, this means you'll supply the changes in the coming day/s?

@IQubic
Copy link
Author

IQubic commented Jun 28, 2020

@worldofpeace I wasn't aware that I had to supply the changes myself, I thought that anyone with push access to the repo could make the changes for me. Sorry about that. I'll get on this right away.

@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@@ -8869,4 +8869,10 @@
github = "cpcloud";
githubId = 417981;
};
iqubic = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be sorted alphabetical

Comment on lines +26 to +27
enableParallelBuilding = true;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enableParallelBuilding = true;

done by qmake

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 7, 2022
@davidak
Copy link
Member

davidak commented Nov 14, 2022

The project looks abandoned. No commit since Sep 28, 2019.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 21, 2023
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 12, 2023
@Janik-Haag
Copy link
Member

Will close the pr since the project is almost definitively stale.

@Janik-Haag Janik-Haag closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants