alacritty: link binary inside .app on darwin #89737
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise you end up with two binaries, only one of which is stripped.
This causes an extra 4.3MB, because 'make app' does another cargo build
and copies that binary into the .app.
Motivation for this change
Installing alacritty on darwin right now causes two binaries to be created, only one of which is stripped.
In this PR I'm overwriting the binary inside the .app with a link to the binary inside bin/. The build still compiles the binary twice, but preventing that would require a patch to the Makefile
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)