Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmerfem: init at release-8.4 #85962

Merged
merged 2 commits into from May 2, 2020
Merged

elmerfem: init at release-8.4 #85962

merged 2 commits into from May 2, 2020

Conversation

Wulfsta
Copy link
Member

@Wulfsta Wulfsta commented Apr 24, 2020

Motivation for this change

Add Elmer FEM to Science/Physics.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Wulfsta
Copy link
Member Author

Wulfsta commented Apr 25, 2020

Cleaned up commits to align with contributing guidelines.

@Wulfsta
Copy link
Member Author

Wulfsta commented Apr 25, 2020

@GrahamcOfBorg build elmerfem

@Wulfsta
Copy link
Member Author

Wulfsta commented Apr 25, 2020

Split commit and added changes, probably not in the ideal way.

@Wulfsta Wulfsta requested a review from jonringer April 25, 2020 20:35
@Wulfsta Wulfsta requested a review from jonringer April 26, 2020 02:13
@jonringer
Copy link
Contributor

please squash the last two commits:

git reset HEAD^
git add pkgs/
git commit --amend --no-edit
git push .. .. --force

@Wulfsta
Copy link
Member Author

Wulfsta commented Apr 27, 2020

@jonringer Squashed, could you take a look at this when you have a chance? Thanks!

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/85962
1 package built:
elmerfem

@jonringer jonringer merged commit 5dbc4f7 into NixOS:master May 2, 2020
@jonringer
Copy link
Contributor

Congrats on your first PR @Wulfsta

Sorry, i was busy :)

@Wulfsta
Copy link
Member Author

Wulfsta commented May 2, 2020

@jonringer Thanks, there will be another shortly! And don't apologize, there was no rush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants