Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/qemu-vm: don't set -vga std #85961

Merged
merged 1 commit into from Apr 27, 2020
Merged

nixos/qemu-vm: don't set -vga std #85961

merged 1 commit into from Apr 27, 2020

Conversation

worldofpeace
Copy link
Contributor

This has been default since QEMU 2.2, it also prevents using a different
-vga

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/qemu-vm: don't set -vga std
d17485c 
This has been default since QEMU 2.2, it also prevents using a different
-vga
@worldofpeace
Copy link
Contributor Author

perhaps @cleverca22 ?

@teto teto merged commit a7ca287 into NixOS:master Apr 27, 2020
@worldofpeace worldofpeace deleted the qemu-dont-force-std branch April 27, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @teto