Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asttokens: 1.1.13 -> 2.0.4 #85981

Merged
merged 1 commit into from Apr 25, 2020
Merged

asttokens: 1.1.13 -> 2.0.4 #85981

merged 1 commit into from Apr 25, 2020

Conversation

renatoGarcia
Copy link
Member

Motivation for this change

Updating to a new released version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Apr 25, 2020

https://github.com/gristlabs/asttokens/releases
Major version bump notes suggest a relatively light change to the parser, so if this all builds I'd say it's good to go.

@bhipple
Copy link
Contributor

bhipple commented Apr 25, 2020

Result of nixpkgs-review pr 85981 1

4 packages built:
- python27Packages.asttokens
- python37Packages.asttokens
- python38Packages.asttokens
- thonny

@bhipple bhipple merged commit ef4a545 into NixOS:master Apr 25, 2020
@renatoGarcia renatoGarcia deleted the asttokens branch April 25, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@renatoGarcia @bhipple