Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gitea: add settings option #85904

Merged
merged 1 commit into from May 5, 2020
Merged

nixos/gitea: add settings option #85904

merged 1 commit into from May 5, 2020

Conversation

aanderse
Copy link
Member

Motivation for this change

#57671

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ping @kolaente is this what you'd like to see?

Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aanderse aanderse requested a review from infinisil April 24, 2020 16:06
@Ma27 Ma27 self-requested a review April 24, 2020 18:28
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looking good!

@aanderse aanderse requested review from etu and srhb April 25, 2020 21:56
@aanderse
Copy link
Member Author

ping @pvgoran

@aanderse aanderse marked this pull request as ready for review April 25, 2020 21:56
@aanderse
Copy link
Member Author

@GrahamcOfBorg test gitea.mysql gitea.postgres gitea.sqlite3

@pvgoran
Copy link
Contributor

pvgoran commented Apr 28, 2020

This is a straightforward improvement, I like it. I didn't review the code (only looked at it briefly) and didn't test it, though.

It lacks documentation, though. :) I mean, the description is just a link to another (draft) PR, and that PR is about a specific setting.

@aanderse
Copy link
Member Author

I wasn't able to reproduce this error locally. Does anyone have any ideas on that?

@aanderse
Copy link
Member Author

aanderse commented May 5, 2020

@GrahamcOfBorg test gitea.mysql
@GrahamcOfBorg test gitea.postgres
@GrahamcOfBorg test gitea.sqlite3

@aanderse
Copy link
Member Author

aanderse commented May 5, 2020

I guess the failure was a glitch in the matrix 🤷‍♂️

@aanderse aanderse merged commit 39a0020 into NixOS:master May 5, 2020
@aanderse aanderse deleted the gitea branch May 5, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants