New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/gitea: add settings option #85904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looking good!
ping @pvgoran |
@GrahamcOfBorg test gitea.mysql gitea.postgres gitea.sqlite3 |
This is a straightforward improvement, I like it. I didn't review the code (only looked at it briefly) and didn't test it, though. It lacks documentation, though. :) I mean, the description is just a link to another (draft) PR, and that PR is about a specific setting. |
I wasn't able to reproduce this error locally. Does anyone have any ideas on that? |
@GrahamcOfBorg test gitea.mysql |
I guess the failure was a glitch in the matrix 🤷♂️ |
Motivation for this change
#57671
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)ping @kolaente is this what you'd like to see?