Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ftp with https for ftp.gnu.org #85942

Merged
merged 1 commit into from Apr 25, 2020
Merged

Replace ftp with https for ftp.gnu.org #85942

merged 1 commit into from Apr 25, 2020

Conversation

kevinastock
Copy link
Contributor

ftp.gnu.org intends to disable the FTP protocol for downloads on this
server, and strongly recommends using https instead.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bhipple
bhipple requested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's change the commit msg to

aspell, tla: use HTTPS instead of FTP

Then I'll merge and let's backport it to 20.03.

@kevinastock
aspell, tla: use HTTPS instead of FTP
295475a 
ftp.gnu.org intends to disable the FTP protocol for downloads on this
server, and strongly recommends using https instead.
bhipple
bhipple approved these changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified I was able to reproduce the same hash from the HTTPS url.

@bhipple bhipple merged commit 719df72 into NixOS:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@bhipple bhipple bhipple approved these changes

@emilazy emilazy emilazy approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinastock @prusnak @bhipple @emilazy