Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urdfdom, console-bridge: init #85983

Merged
merged 3 commits into from Jul 8, 2020
Merged

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Adds some packages that are required by newer versions of the Gazebo simulator. The Gazebo updates will be upstreamed later after I have cleaned them up. console-bridge is also an important ROS dependency, so this PR will make my ROS overlay less dependent on my nixpkgs fork.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/154

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and --help test (of urdfdom).

@lopsided98
Copy link
Contributor Author

I updated console-bridge to 1.0.0 and urdfdom-headers to 1.0.5.

@lopsided98
Copy link
Contributor Author

lopsided98 commented Jul 5, 2020

I implemented the correct fix for the pkg-config relative path problem in urdfdom (as suggested by @jtojnar in another PR).

@lopsided98
Copy link
Contributor Author

I added another patch for the same kind of CMake problem in urdfdom-headers.

@jtojnar jtojnar added this to Done in CMake breakage Jul 8, 2020
@jtojnar jtojnar merged commit 6dbcca5 into NixOS:master Jul 8, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 8, 2020

Thanks.

@lopsided98 lopsided98 deleted the gazebo-prereqs branch July 8, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants