New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urdfdom, console-bridge: init #85983
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/154 |
9df42fa
to
cdf8c7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes nixpkgs-review
build and --help
test (of urdfdom).
cdf8c7f
to
38da470
Compare
I updated console-bridge to 1.0.0 and urdfdom-headers to 1.0.5. |
38da470
to
bff5ee4
Compare
I implemented the correct fix for the pkg-config relative path problem in urdfdom (as suggested by @jtojnar in another PR). |
bff5ee4
to
d2f0ba7
Compare
I added another patch for the same kind of CMake problem in |
d2f0ba7
to
1fd080c
Compare
Thanks. |
Motivation for this change
Adds some packages that are required by newer versions of the Gazebo simulator. The Gazebo updates will be upstreamed later after I have cleaned them up.
console-bridge
is also an important ROS dependency, so this PR will make my ROS overlay less dependent on my nixpkgs fork.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)