similar (stalled) pull requests: #70058

@Mic92 that PR follows the same binary-downloading approach I mentioned in the description. This PR should be better.

Yes. This one seems better.

This looks great! I'm just wondering if there should be a microsoft somewhere in the package name to distinguish it from the palantir python module.

So I am trying to test it, I have got your branch and could run successfully nix-env -iA python-language-server. I have the error thomasjm, which just confirms the issue detected by the CI.

Let me know if I can help with anything else.

@mjlbach thanks! Yeah I wondered that too, I looked over Nixpkgs and didn't see too many organization names so I left it out for now, although there's definitely possibility for confusion here. Maybe someone with more Nix experience can make a suggestion about how to disambiguate from Palantir's version.

@pedrovelho thanks for testing it -- could you clarify what the issue you saw was? If it was related to the maintainers issue that seems to be fixed in the CI now.

Update: I finally encountered #73810 myself so I was able to push a fix. Would appreciate if you tried it again @pedrovelho.

Latest commit has some other changes also.

I confirm the maintainers issue is gone. It does not work on my machine but I am not sure this is a problem only I have. It is strange but I have the same behavior as vscode-with-extensions, it is like the binary is not executable on my architecture.

$ ls /nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer
/nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer
$ /nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer 
zsh: no such file or directory: /nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer
$ /usr/bin/bash /nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer
zsh: no such file or directory: /usr/bin/bash
$ /usr/bin/env bash /nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer
/nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer: /nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer: cannot execute binary file
 $ ldd /nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/lib/Microsoft.Python.LanguageServer
	linux-vdso.so.1 (0x00007fffaed7e000)
	libpthread.so.0 => /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread.so.0 (0x00007fc7153d0000)
	libdl.so.2 => /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libdl.so.2 (0x00007fc7153cb000)
	libstdc++.so.6 => not found
	libm.so.6 => /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libm.so.6 (0x00007fc71528b000)
	libgcc_s.so.1 => /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libgcc_s.so.1 (0x00007fc715271000)
	libc.so.6 => /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc.so.6 (0x00007fc7150b2000)
	/lib64/ld-linux-x86-64.so.2 => /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib64/ld-linux-x86-64.so.2 (0x00007fc7153f3000)

I installed it by cloning your fork, checking out your branch, and using the export NIXPKGS=~/tmpdev/nixpkgs as described on the wiki. I finally installed it using nix-env -f $NIXPKGS -iA python-language-server. Please let me know if I am not installing it right.

My architecture if it helps.

> uname -a 
Linux fox 5.4.33 #1-NixOS SMP Fri Apr 17 08:50:26 UTC 2020 x86_64 GNU/Linux

You want the version under bin, something like /nix/store/nmrdpcsr4hp2inqm0691ndgw9b6cql9i-python-language-server-2020-04-17/bin/python-language-server. I suspect your lack of libstdc++.so.6 is some other problem...

@ofborg build python-language-server

Why does this contribution target release-20.03? All new contributions should target master.

@GrahamcOfBorg build python-language-server

The darwin issue seems to be in dotnet

Cannot nix-instantiate `python-language-server' because:
warning: ignoring the user-specified setting 'restrict-eval', because it is a restricted setting and you are not a trusted user
error: while evaluating the attribute 'buildInputs' of the derivation 'python-language-server-2020-04-17' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:191:11:
while evaluating the attribute 'handled' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/check-meta.nix:251:7:
while evaluating 'handleEvalIssue' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/check-meta.nix:147:38, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/check-meta.nix:252:14:
Package ‘dotnet-sdk-3.1.101’ in /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/compilers/dotnet/buildDotnet.nix:63 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg build python-language-server

Whoops missed a few, hang on

@GrahamcOfBorg build python-language-server

Sweet. After we land this a separate PR can replace the server used in vscode-extensions with this one.

Sadly nixpkgs-review pr 85930 doesn't work for me locally because I use a different Nix root from /nix and it doesn't like that, but glad you two were able to build.

Issues I still see blocking this:

• aarch64 build fails, see https://github.com/NixOS/nixpkgs/pull/85930/files#r417516626 for comments.
• PR should be renamed to something like python-language-server: init at (INSERT_VERSION)

Just addressed both

@GrahamcOfBorg build python-language-server

Thank you both for the review!

Please hold off on merging for now, I've been trying to use it a bit more and identified another linker problem that can happen at runtime (involving openssl this time, there's some discussion about the same problem on #73810).

@GrahamcOfBorg build python-language-server

I've been using this for the past week and have thus far not run into any issues!

Oh that reminds me, I've been using it as well and it seems fine after the last couple tweaks. I just re-squashed and re-rebased on master. I think this is ready to merge anytime.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/151

Maybe the vscode extension package should be linking to this one instead?